[Bug 30430] Make wocky_implement_finish_* macros safer
bugzilla-daemon at freedesktop.org
bugzilla-daemon at freedesktop.org
Mon Dec 20 20:53:18 CET 2010
https://bugs.freedesktop.org/show_bug.cgi?id=30430
--- Comment #16 from Will Thompson <will.thompson at collabora.co.uk> 2010-12-20 11:53:18 PST ---
Review of attachment 41309:
--> (https://bugs.freedesktop.org/review?bug=30430&attachment=41309)
::: wocky/wocky-porter.c
@@ +1421,3 @@
+ /* The cancellable must be NULL, otherwise it will be leaked */
+ g_assert (priv->close_cancellable == NULL);
+
If there's a comment here at all, it should be to say that, since we guarded
against close_async() being called more than once, this assertion should be
safe. Ditto the comment below.
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
More information about the telepathy-bugs
mailing list