[Bug 24902] interface for precomposed dial-strings

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=24902


Olivier Crête <tester at tester.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tester at tester.ca




--- Comment #3 from Olivier Crête <tester at tester.ca>  2010-02-02 00:25:50 PST ---
We should probably reconsider how starttone/stoptone work vs dialstring, I'm
not happy at having two different API calls that do more or less the same thing
but in slighly different ways. Maybe we should just drop start/stop entirely
and only keep SendDialString().

(In reply to comment #2)
> (In reply to comment #1)
> > This API is merely a shortcut for DTMF.  Rather than individually calling
> > DTMF.StartTone and DTMF.StopTone, the DialStrings interface allows one to send
> > a batch of tones to the modem.
> > 
> >  - SendDialString(u:Stream_ID, s:DialString, u:Duration, u:Pause
> 
> 
> This should probably be merged into a DTMF spec.  Stream_ID should be dropped
> (as we're planning to do for DTMF). 

The new DTMF/Dialstring interface should be moved on top of the Call.Content
interface. It affects the "audio content", so it is its natural home.

> > The DialString arg here is a string of DTMF tones; each tone is (theoretically)
> > played for Duration ms, followed by Pause ms of silence (in actuality for
> > something like a GSM modem that knows how to handle a  DTMF string, the
> > Pause/Duration arguments end up being ignored unless the hardware API accepts
> > them).
> > 
> >  - CancelDialString(u:Stream_ID)
> 
> If SendDialString is added to DTMF, I don't see why StopTone couldn't be used
> in place of CancelDialString.  It simplifies the interface a lot; StopTone
> stops any tones from playing, whether it's a single tone (started w/
> StartTone), or a set of tones (started w/ SendDialString).

That won't work. Currently you can call start(1)/stop/start(2)/stop without
pause and it will be the same as sending the "12" dialstring. That said, I
don't think anyone actually uses that method, so I'd just drop it.


> >  - GetCurrentDialStrings(Stream_ID) => a{us}:Dial_Strings
> > 
> > A map of Stream_ID to DialStrings currently being sent.
> 
> I'm not convinced that this is useful.  I'm also not convinced that it's not
> racy for a client to be using this to make any decisions about handling
> dialstrings.  I suggest dropping it.

I agree, drop it. I don't think any client actually uses it.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.