[Bug 22706] [0.11] GNIO integration for Telepathy GLib

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=22706


Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |review+




--- Comment #9 from Simon McVittie <simon.mcvittie at collabora.co.uk>  2010-02-22 01:49:24 PST ---
This looks good for merge, thanks.

Things that do not block merge but would be nice to see in a trivia branch as a
follow-up (or you can do them before merging, and consider them pre-reviewed):

> +  AC_DEFINE(HAVE_GIO_UNIX, [], [GIO-Unix is available])

This string turns up in config.h.in, which is (in principle) hand-editable for
use on platforms that can't run configure, so it should be "Define if GIO-Unix
is available".

> +GValue *tp_address_variant_from_g_socket_address (GSocketAddress      *address,

Please remove the excess spaces.

You still haven't done this:
> > I'd like ABST_ATTR to have some specified trailing rubbish -
> > "\x00pqrstuXYZ\x00" or something - to be able to assert that XYZ is
> > *not* copied even though there's no terminating NUL.
>
> Will do when I write some more tests.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.