[Bug 26014] gateway registration plugin doesn't actually exchange subscriptions

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=26014


Will Thompson <will.thompson at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |review+ish




--- Comment #3 from Will Thompson <will.thompson at collabora.co.uk>  2010-02-22 10:16:08 PST ---
When you're normalizing, why not do:

if (!wocky_decode_jid (gateway, &node, &domain, &resource))
  blow up;

if (node != NULL || resource != NULL)
  blow up;

rather than manually looking for @ and / yourself? Maybe this would actually
make the code longer.

I could possibly be convinced that wocky_decode_jid() should blow up itself if
the node param is NULL but the jid has a node...

+      /* attempt to subscribe to the gateway's presence (FIXME: is this
+       * harmless if we're already subscribed to it?) */

Yeah, I think it is.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.