[Bug 26712] New: Telepathy-logger should support storing and retrieving favorite Telepathy contacts

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=26712

           Summary: Telepathy-logger should support storing and retrieving
                    favorite Telepathy contacts
           Product: Telepathy
           Version: unspecified
          Platform: Other
               URL: http://git.collabora.co.uk/?p=user/treitter/telepathy-
                    logger.git;a=shortlog;h=favorites-try2
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: logger
        AssignedTo: telepathy-bugs at lists.freedesktop.org
        ReportedBy: travis.reitter at collabora.co.uk
                CC: danielle.madeley at collabora.co.uk


It'd be handy and nicely-centralized to have the Telepathy logger store and
manage a set of favorite Telepathy contacts.

I've created a branch of the logger which adds and implements a simple API for
this. The upside to doing this in one place is that different Telepathy-based
IM clients can use the same set of favorites.

Danielle, could you please review this?

You can browse my branch at the given URL (it's up-to-date with the mainline,
as of this writing).

The only change is the last commit (though it's several hundred lines;
splitting it didn't seem useful).

There are a few open questions (comments including the keyword "XXX"). One of
the bigger ones (which may or may not still have a comment in my latest
version) is whether the favorite contacts functionality should have its own
namespace (vs. org.freedesktop.Telepathy.Logger[.DRAFT]).

I also wish I could have avoided the FavouriteContactsIsReady property and
FavouriteContactsReady signal altogether. But there doesn't seem to be any
other way that doesn't either expose a race condition between the logger
deserializing the favorite contacts file or adding some excessive
infrastructure (like queues for method calls that arrive between the start and
end of that deserialization). Beyond that, the first is gramatically awkward
(and inappropriate for a property?) and they sound like synonyms to me anyhow.

I'm looking forward to any and all critiques.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.