[Bug 19605] Gabble should cache client capabilities

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=19605


Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://git.collabora.co.uk/?|http://git.collabora.co.uk/?
                   |p=user/daf/telepathy-       |p=user/smcv/telepathy-
                   |gabble;a=shortlog;h=refs/hea|gabble-
                   |ds/caps-cache-0.9           |smcv.git;a=shortlog;h=refs/h
                   |                            |eads/caps-cache
           Keywords|                            |patch
          QAContact|                            |telepathy-
                   |                            |bugs at lists.freedesktop.org
  Status Whiteboard|review-                     |




--- Comment #7 from Simon McVittie <simon.mcvittie at collabora.co.uk>  2010-02-24 08:20:45 PST ---
(In reply to comment #6)
> So the free function for GabbleCapsCache::cache is wrong.

The offending code was removed by a subsequent patch, so it doesn't actually
matter.

> I think http://git.collabora.co.uk/?p=telepathy-gabble.git;a=commit;h=099bb4534
> needs cherry-picking.

Done.

I also cherry-picked the regression test (but not the code changes) from
2ce3ea29b7 "restore per-channel-manager caps from the cache", to verify that
those code changes are not needed in 0.9 (the test passes, so apparently
they're not).


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.