[Bug 25766] Review Gabble Google Mail Notification

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=25766





--- Comment #16 from Simon McVittie <simon.mcvittie at collabora.co.uk>  2010-02-25 11:33:54 PST ---
(In reply to comment #11)
> Ported yesterday, but if we undraft we still need to update.

The spec isn't ready to be undrafted just yet (I'd prefer to get a draft
implementation merged in Gabble, and at least nearly-ready in one of the other
CMs, first), so please just make sure it's in sync with the draft in the 0.19.1
spec release, by copying in the one from the 0.19.1 spec, verbatim.

This will include non-functional changes, like the <tp:added> notation - that's
desirable, it indicates more clearly which version we claim to implement.

As far as I can tell, it will also change the type of URL_Data from string to
variant, which will require some code fixes. You'd have spotted this if you'd
copied in the spec XML from 0.19.1 verbatim, rather than picking out individual
changes.

Remaining merge blockers, which are all simple changes: use
tp_value_array_build(), correct copyright years, typedef the struct, file an
enhancement/low bug for pre-authenticated URLs, and either reference that bug
by its fd.o bug number in the TODO comments or just remove them.

Getting our own JID via tp_base_connection_get_self_handle would be nice, but
isn't a blocker; the spec clarification I requested in Comment #15 blocks
undrafting (IMO), but doesn't block this branch.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.