[Bug 25766] Review Gabble Google Mail Notification

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=25766


Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |13349
             Blocks|13349                       |




--- Comment #17 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk>  2010-02-25 11:42:16 PST ---
(In reply to comment #13)
> In the case of XMPP, users are identified by JIDs, so the self-handle is (an
> integer that maps to) the user's own JID.

Ok, looking at the code I find it harder to understand, but it works:
commit 77b7ccb1562ff8d367048383ee921652e7f7024b
    Use SelfHandle instead of username at stream_server MailAddress

Also I found that MailAddress was not covered in the test:
commit b011ce16a3c61fea0234024080d67c71ef99de00
    Test MailNotification.MailAddress property

And the RequestMailURL was not testing the actual result:
commit 994946151237c04b45e9338a9445f2260f94e119
    Test the value returned by MailNotification.RequestMailUrl


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.