[Bug 25766] Review Gabble Google Mail Notification

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=25766





--- Comment #18 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk>  2010-02-25 12:04:55 PST ---
(In reply to comment #16)
> (In reply to comment #11)
> > Ported yesterday, but if we undraft we still need to update.
> 
> The spec isn't ready to be undrafted just yet (I'd prefer to get a draft
> implementation merged in Gabble, and at least nearly-ready in one of the other
> CMs, first), so please just make sure it's in sync with the draft in the 0.19.1
> spec release, by copying in the one from the 0.19.1 spec, verbatim.
> 
> This will include non-functional changes, like the <tp:added> notation - that's
> desirable, it indicates more clearly which version we claim to implement.

Good idea, I didn't notice you had added a version.

> 
> As far as I can tell, it will also change the type of URL_Data from string to
> variant, which will require some code fixes. You'd have spotted this if you'd
> copied in the spec XML from 0.19.1 verbatim, rather than picking out individual
> changes.

Only the commit with the version number is (btw the file is from master
verbatim, no picking of individual changes was ever done). The variant stuff is
already in too, I accidentally included it in another commit, sorry, I'll
rebase and split this:

commit 8ff0447245fab74dcebe23bfc5b5b8de06efb743
    Mail_Type has been replaced by a THREAD_BASED flag

Has we don't use url-data in this implementation, the change is very small. The
relevant part of the patch was the following:

--- a/src/conn-mail-notif.c
+++ b/src/conn-mail-notif.c
@@ -244,7 +244,7 @@ static void
 gabble_mail_notification_request_mail_url (
     GabbleSvcConnectionInterfaceMailNotification *iface,
     const gchar *in_id,
-    const gchar *in_url_data,
+    const GValue *in_url_data,
     DBusGMethodInvocation *context)
 {
   GabbleConnection *conn = GABBLE_CONNECTION (iface);


> 
> Remaining merge blockers, which are all simple changes: use
> tp_value_array_build(), correct copyright years, typedef the struct, file an
> enhancement/low bug for pre-authenticated URLs, and either reference that bug
> by its fd.o bug number in the TODO comments or just remove them.
> 
> Getting our own JID via tp_base_connection_get_self_handle would be nice, but
> isn't a blocker; the spec clarification I requested in Comment #15 blocks
> undrafting (IMO), but doesn't block this branch.

JID stuff has been changed now. About the email common name clarification I'll
introduce it in Spec review bug.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.