[Bug 26750] make GetRecentMessages async

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=26750


Danielle Madeley <danielle.madeley at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #2 from Danielle Madeley <danielle.madeley at collabora.co.uk>  2010-02-25 18:32:27 PST ---
(In reply to comment #1)
> +      /* messages will be NULL, we can just continue */
> 
> Preferably, I'd also set messages to NULL just below that comment just to be
> explict and safer (and update the comment according).

Yeah. Good call.

> +  ctx->ptr = g_list_last (ctx->dates);
> 
> Since this relies upon the chronological ordering of the return value of
> tpl_log_manager_get_dates(), could you update the documentation for that
> function to make that guarantee?

The function builds sorted lists, but we actually intend to update the function
at some point to allow the list to be presorted in either direction (based on
an explicit enum). Will leave it for now.

> Looks like you're leaking the ctx and its allocated members in case ctx->dates
> is NULL.

Good catch.

> If you agree with the changes, feel free to just make them and merge.

Thanks. Done.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.