[Bug 20831] ContactInfo: implement and undraft

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=20831


Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |review+




--- Comment #18 from Simon McVittie <simon.mcvittie at collabora.co.uk>  2010-02-26 04:26:30 PST ---
[Adding review+ to whiteboard based on Comment #17]

So, remaining problems I see with this code:

* The SupportedFields property is not connection-specific, so we can't separate
it for GTalk. My suggestion would be to have a "filtered" version for less
capable connections (GTalk, right now), and a global "unfiltered" version for
connections where we think we can set everything.

* It's permissive about incoming vCard fields, but then silently drops anything
it doesn't like. My instinct is that in an initial implementation, we should
fail loudly (InvalidArgument) on any input we don't like, to encourage initial
UIs to actually check SupportedFields. We can relax this later if silently
dropping fields turns out to be preferred.

* SupportedFields should list their supported type-parameters, and
SupportedFields that can't have any type-parameters at all should have the
Parameters_Mandatory flag.

* Minor: it would be nice to detect the Facebook XMPP server, and on
connections to that server, clear the SupportedFields and the Can_Set bit.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.