[Bug 26004] New: Missing include in types.h

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=26004

           Summary: Missing include in types.h
           Product: Telepathy
           Version: git master
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: tp-qt4
        AssignedTo: telepathy-bugs at lists.freedesktop.org
        ReportedBy: dariusz.mikulski at collabora.co.uk
                CC: dariusz.mikulski at collabora.co.uk


telepathy-qt4-0.2.0 (latest version using automake 1.8.5 from maemo) with Qt
4.6 from maemo extras-devel repo can't build on Maemo 5.
Problem is in TelepathyQt4/types.h where define
HAVE_QDBUSVARIANT_OPERATOR_EQUAL is checked. It's already defined in config.h
but this file isn't included in types.h

Patch is in attachment.

Compilation error:

/opt/qt4-maemo5/bin/moc -DBUILDING_TELEPATHY_QT4 -I.. -I.. -DQT_SHARED
-I/opt/qt4-maemo5/include -I/opt/qt4-maemo5/include/QtCore   -DQT_SHARED
-I/opt/qt4-maemo5/include -I/opt/qt4-maemo5/include/QtDBus
-I/opt/qt4-maemo5/include/QtCore -I/opt/qt4-maemo5/include/QtXml   -DQT_SHARED
-I/opt/qt4-maemo5/include -I/opt/qt4-maemo5/include/QtNetwork
-I/opt/qt4-maemo5/include/QtCore -I/opt/qt4-maemo5/include/QtDBus
-I/opt/qt4-maemo5/include/QtXml   -i abstract-interface.h -o
_gen/abstract-interface.moc.hpp
make  all-recursive
make[3]: Entering directory `/home/malcolm/source/telepathy-qt4/TelepathyQt4'
Making all in .
make[4]: Entering directory `/home/malcolm/source/telepathy-qt4/TelepathyQt4'
if /bin/sh ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I. -I..
 -DBUILDING_TELEPATHY_QT4 -I.. -I.. -DQT_SHARED -I/opt/qt4-maemo5/include
-I/opt/qt4-maemo5/include/QtCore   -DQT_SHARED -I/opt/qt4-maemo5/include
-I/opt/qt4-maemo5/include/QtDBus -I/opt/qt4-maemo5/include/QtCore
-I/opt/qt4-maemo5/include/QtXml   -DQT_SHARED -I/opt/qt4-maemo5/include
-I/opt/qt4-maemo5/include/QtNetwork -I/opt/qt4-maemo5/include/QtCore
-I/opt/qt4-maemo5/include/QtDBus -I/opt/qt4-maemo5/include/QtXml    -Wall
-Wextra -Wsign-compare -Wpointer-arith -Wformat-security -Winit-self
-Wno-missing-field-initializers -Wno-unused-parameter -g -O2 -MT
abstract-client.lo -MD -MP -MF ".deps/abstract-client.Tpo" -c -o
abstract-client.lo abstract-client.cpp; \
        then mv -f ".deps/abstract-client.Tpo" ".deps/abstract-client.Plo";
else rm -f ".deps/abstract-client.Tpo"; exit 1; fi
 g++ -DHAVE_CONFIG_H -I. -I. -I.. -DBUILDING_TELEPATHY_QT4 -I.. -I..
-DQT_SHARED -I/opt/qt4-maemo5/include -I/opt/qt4-maemo5/include/QtCore
-DQT_SHARED -I/opt/qt4-maemo5/include -I/opt/qt4-maemo5/include/QtDBus
-I/opt/qt4-maemo5/include/QtCore -I/opt/qt4-maemo5/include/QtXml -DQT_SHARED
-I/opt/qt4-maemo5/include -I/opt/qt4-maemo5/include/QtNetwork
-I/opt/qt4-maemo5/include/QtCore -I/opt/qt4-maemo5/include/QtDBus
-I/opt/qt4-maemo5/include/QtXml -Wall -Wextra -Wsign-compare -Wpointer-arith
-Wformat-security -Winit-self -Wno-missing-field-initializers
-Wno-unused-parameter -g -O2 -MT abstract-client.lo -MD -MP -MF
.deps/abstract-client.Tpo -c abstract-client.cpp  -fPIC -DPIC -o
.libs/abstract-client.o
In file included from ../TelepathyQt4/Types:8,
                 from ../TelepathyQt4/abstract-client.h:30,
                 from ../TelepathyQt4/AbstractClient:8,
                 from abstract-client.cpp:22:
../TelepathyQt4/types.h: In function 'bool operator==(const QDBusVariant&,
const QDBusVariant&)':
../TelepathyQt4/types.h:102: error: redefinition of 'bool operator==(const
QDBusVariant&, const QDBusVariant&)'
/opt/qt4-maemo5/include/QtDBus/qdbusextratypes.h:177: error: 'bool
operator==(const QDBusVariant&, const QDBusVariant&)' previously defined here


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.