[Bug 27997] TpBaseProtocol and TpProtocol in tp-glib

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27997

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|TpBaseProtocol (and stub    |TpBaseProtocol and
                   |TpProtocol) in tp-glib      |TpProtocol in tp-glib
                URL|http://git.collabora.co.uk/ |http://git.collabora.co.uk/
                   |?p=user/smcv/telepathy-glib |?p=user/andrunko/telepathy-
                   |-smcv.git;a=shortlog;h=refs |glib.git;a=shortlog;h=refs/
                   |/heads/protocol-export-2    |heads/protocol
  Status Whiteboard|r+                          |review+

--- Comment #5 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-07-01 03:37:21 PDT ---
Over on Bug #27998, Andre wrote:
> Rebased with upstream master and fixed some issues with tests+conflicts in docs
> mainly.
>
> The branch is at
> http://git.collabora.co.uk/?p=user/andrunko/telepathy-glib.git;a=shortlog;h=refs/heads/protocol

I've got rid of my branches in favour of this one, but in future I'd much
prefer it if you didn't rebase other people's branches - it makes it difficult
to work out what has changed, and introduces a lot of commits which would never
actually have worked or even compiled.

A non-trivial merge of master into the branch, or the branch into a copy of
master, with appropriate changes to make it compile and work again, would have
preserved the history, and preserved the general principle that after each
commit, the code should be (at least mostly) usable.

> Just one thing I missed in the review. The methods on Protocol
> (IdentifyAccount, NormalizeContact) are not implemented in client code, should
> they be? I didn't implement them in tp-qt4 either.

Do you mean that generated tp_cli functions are missing, or that high-level
wrappers are missing?

As long as we have the generated tp_cli functions, I think we can defer
high-level wrappers until a bit later, although we should open a bug for them
so they don't get lost.

> I am using this rebased branch as requirement for tp-qt4 tests for Protocol
> objects, as I need the changed echo2 and the addition of protocol in
> ConnectionManager, ...

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.