[Bug 27997] TpBaseProtocol and TpProtocol in tp-glib

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27997

Andre Moreira Magalhaes <andrunko at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://git.collabora.co.uk/ |http://git.collabora.co.uk/
                   |?p=user/smcv/telepathy-glib |?p=user/smcv/telepathy-glib
                   |.git;a=shortlog;h=refs/head |-smcv.git;a=shortlog;h=refs
                   |s/protocol                  |/heads/protocol

--- Comment #7 from Andre Moreira Magalhaes <andrunko at gmail.com> 2010-07-01 07:38:40 PDT ---
(In reply to comment #5)
> Over on Bug #27998, Andre wrote:
> > Rebased with upstream master and fixed some issues with tests+conflicts in docs
> > mainly.
> >
> > The branch is at
> > http://git.collabora.co.uk/?p=user/andrunko/telepathy-glib.git;a=shortlog;h=refs/heads/protocol
> 
> I've got rid of my branches in favour of this one, but in future I'd much
> prefer it if you didn't rebase other people's branches - it makes it difficult
> to work out what has changed, and introduces a lot of commits which would never
> actually have worked or even compiled.
> 
> A non-trivial merge of master into the branch, or the branch into a copy of
> master, with appropriate changes to make it compile and work again, would have
> preserved the history, and preserved the general principle that after each
> commit, the code should be (at least mostly) usable.
Sure, I will keep that in mind next time. I just wanted to have something
working so I could work on tp-qt4 tests for Protocol easily.

> > Just one thing I missed in the review. The methods on Protocol
> > (IdentifyAccount, NormalizeContact) are not implemented in client code, should
> > they be? I didn't implement them in tp-qt4 either.
> 
> Do you mean that generated tp_cli functions are missing, or that high-level
> wrappers are missing?
> 
> As long as we have the generated tp_cli functions, I think we can defer
> high-level wrappers until a bit later, although we should open a bug for them
> so they don't get lost.
The high-level wrappers are missing, low-level methods are there. So I keep r+
here and we should open bugs to implement the missing high-level methods later.
Same for tp-qt4 impl found at andrunko/cm-protocol that does not wrap these
methods.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.