[Bug 28902] Implement Account.Service property

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28902

Will Thompson <will.thompson at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|r-, minor                   |r-, minorer

--- Comment #4 from Will Thompson <will.thompson at collabora.co.uk> 2010-07-05 10:03:02 PDT ---
+        g_set_error (error, TP_ERRORS, TP_ERROR_INVALID_ARGUMENT,
+                     "Service cannot be set to '%s' (%s)",
+                     g_value_get_string (value),
+                     G_VALUE_TYPE_NAME (value));

What's the point of including the type name? we know it's a string (don't we?
doesn't MC's property fu ensure that? if it doesn't we'll already have
critical'd from the g_value_get_string()s). And this error would be more useful
if it said something like "'%s' is an invalid service name; service names
consist only of ASCII letters, numbers and hyphen/minus signs, and start with a
letter".

+    /* fall back to the protocol if nothing is explicitly set, as per spec */
+    if (g_value_get_string (value) == NULL)
+        g_value_set_string (value, "");

Comment no match code.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.