[Bug 27792] add Vala bindings

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Jul 12 16:24:42 CEST 2010


https://bugs.freedesktop.org/show_bug.cgi?id=27792

--- Comment #25 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-07-12 07:24:42 PDT ---
http://git.collabora.co.uk/?p=user/treitter/telepathy-glib.git;a=commitdiff;h=54062f5e3c0c7ff147c8cb0490bbd3a65c59b50e
> Don't implicitly transfer ownership of Contacts' or Connections' TpCapabilities in their getter functions.

That's not what this patch does (and if it did that, it'd be an ABI break). A
better commit message would be "Annotate that TpCapabilities getter functions
don't transfer ownership".

> Expose Capabilities.get_channel_classes() to g-i.

Will this break other g-i consumers?

If not, I'm not against it, but the long commit message seems misleading: you
can use the higher-level convenience methods on TpCapabilities even if you
can't use this one, surely?

> Un-blacklist the tp_asv_get_* utility functions for g-i.

Does @asv need annotating with (element-type)?

I'm not against this, although a parallel GVariant API for a{sv}s would be nice
too.

However, please note that the tp_asv_set_* family are not safe for g-i, so stop
here rather than continuing :-)

(The tp_asv_set_* family require prior knowledge of the memory allocation model
being used for the hash table - are the GValues slice-allocated or g_malloc'd,
and are the strings owned or static? - so they can't safely be used from g-i,
which doesn't have this information.)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.



More information about the telepathy-bugs mailing list