[Bug 27792] add Vala bindings

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27792

Travis Reitter <travis.reitter at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://git.collabora.co.uk/ |http://git.collabora.co.uk/
                   |?p=user/treitter/telepathy- |?p=user/treitter/telepathy-
                   |glib.git;a=shortlog;h=refs/ |glib.git;a=shortlog;h=refs/
                   |heads/gi-fixes2             |heads/gi-fixes3

--- Comment #27 from Travis Reitter <travis.reitter at collabora.co.uk> 2010-07-12 09:42:22 PDT ---
(In reply to comment #25)
> http://git.collabora.co.uk/?p=user/treitter/telepathy-glib.git;a=commitdiff;h=54062f5e3c0c7ff147c8cb0490bbd3a65c59b50e
> > Don't implicitly transfer ownership of Contacts' or Connections' TpCapabilities in their getter functions.
> 
> That's not what this patch does (and if it did that, it'd be an ABI break). A
> better commit message would be "Annotate that TpCapabilities getter functions
> don't transfer ownership".

Fixed in gi-fixes3

> > Expose Capabilities.get_channel_classes() to g-i.
> 
> Will this break other g-i consumers?

I'm not sure if it causes build failures or just gets ignored (it depends on
whether the parser treats it as an error, warning, or nothing).

Danielle, could you address this?

> If not, I'm not against it, but the long commit message seems misleading: you
> can use the higher-level convenience methods on TpCapabilities even if you
> can't use this one, surely?

Sure, I could use higher-level convenience methods, but they currently only
tell us whether the capabilities support 1:1 chat or rooms; we'll need to add a
convenience function per flag value to not need to access the channel classes.

> > Un-blacklist the tp_asv_get_* utility functions for g-i.
> 
> Does @asv need annotating with (element-type)?

Fixed in gi-fixes3

> I'm not against this, although a parallel GVariant API for a{sv}s would be nice
> too.
> 
> However, please note that the tp_asv_set_* family are not safe for g-i, so stop
> here rather than continuing :-)

Done.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.