[Bug 29009] Clarify StreamedMedia group state changes, and DBus_Property parameters

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=29009

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
  Status Whiteboard|                            |review+ with minor changes
         AssignedTo|telepathy-bugs at lists.freede |will.thompson at collabora.co.
                   |sktop.org                   |uk

--- Comment #6 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-07-13 04:27:43 PDT ---
Thanks, this mostly looks good.

> +          from the group. A client may supply a reason when attempting to
> +          remove members from a group with
> +          <tp:member-ref>RemoveMembersWithReason</tp:member-ref>, and are
> +          supplied by the CM when emitting

s/and are supplied by/and reasons are supplied by/ for better grammar?

> Document that locally timed out calls should also be No_Answer.

I think we should also clarify that the CM shouldn't do this unless it has to?
Our position on this has generally been that the timeout is policy, therefore
it's a UI decision, so if anything gives up, it should be the UI, with
RemoveMembersWithReason([SelfHandle], No_Answer).

(I can see that some CMs might not have any choice, if a server or oFono or
whatever does the timing-out, though.)

In Gabble, we historically had a 1 minute timeout, which Daf removed in 2009
(late in the 0.7.x series) to fix Bug #21153.

>+            namespace = namespace.replace('ofdT.', 'org.freedesktop.Telepathy.')

I'd prefer this to be anchored at the beginning:

    if namespace.startswith('ofdT.'):
        namespace = 'org.freedesktop.Telepathy.' + namespace[5:]

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.