[Bug 28192] support for immutable accounts in Mission Control

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Jul 14 02:25:22 CEST 2010


https://bugs.freedesktop.org/show_bug.cgi?id=28192

--- Comment #14 from Will Thompson <will.thompson at collabora.co.uk> 2010-07-13 17:25:21 PDT ---
(In reply to comment #13)
> I'll try pinging on IRC tomorrow if it's not reviewed yet..

+#include "_gen/svc-Account_Interface_Storage.h"

This shouldn't be there any more.

-#include "mission-control-plugins/mission-control-plugins.h"

Intentional?


+guint
+mcp_account_storage_get_restrictions (const McpAccountStorage *storage,
+    const gchar *account)

Shouldn't this return TpStorageRestrictionFlags?


+static gboolean
+_find_account (McdAccountManagerSso *sso,
+    const gchar *account_name,
+    AgAccountId *account_id)

Wait what? Isn't there a better way to map backwards than iterating over every
account? If not, :(

+#define PLUGIN_PROVIDER "org.maemo.Telepathy.Account.Storage.LibAccounts"

We'll want to define this somewhere that other applications can use, but I'm
not sure where off-hand.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.



More information about the telepathy-bugs mailing list