[Bug 29078] use TpBaseProtocol

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=29078

Will Thompson <will.thompson at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |r+ modulo one trivial typo
                   |                            |in a comment.

--- Comment #1 from Will Thompson <will.thompson at collabora.co.uk> 2010-07-16 04:58:03 PDT ---
+  /* FIXME: is it safe to pass a NULL account to prpl_info->account for all
+   * prpls? If it is, we could do that to be more likely to normalize right */
+  return g_strdup (purple_normalize (NULL, contact));

You mean ->normalize, not ->account. And, it seems to be, except for Zephyr
(which will critical). A bunch of the other normalization functions have
comments suggesting that it's not accidental that they work with account ==
NULL. :)

So I think we should do that; or, make purple_normalize() do that. Your call.

This stuff with haze_foo_manager_append_channel_classes, all with identical
implementations, suggests that that should live in tp-glib. Not clear exactly
how, though...

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.