[Bug 28192] support for immutable accounts in Mission Control

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28192

--- Comment #15 from Eitan Isaacson <eitan.isaacson at collabora.co.uk> 2010-07-18 22:56:21 PDT ---
(In reply to comment #14)
> (In reply to comment #13)
> > I'll try pinging on IRC tomorrow if it's not reviewed yet..
> 
> +#include "_gen/svc-Account_Interface_Storage.h"
> 

e927755
> This shouldn't be there any more.
> 
> -#include "mission-control-plugins/mission-control-plugins.h"
> 
e927755

> Intentional?
> 
> 
> +guint
> +mcp_account_storage_get_restrictions (const McpAccountStorage *storage,
> +    const gchar *account)
> 
> Shouldn't this return TpStorageRestrictionFlags?
> 
e927755

> 
> +static gboolean
> +_find_account (McdAccountManagerSso *sso,
> +    const gchar *account_name,
> +    AgAccountId *account_id)
> 
> Wait what? Isn't there a better way to map backwards than iterating over every
> account? If not, :(
> 

Yeah, that is kind of silly. But bomb proof, wasn't familiar enough with the
data model to have a hashtable mapping, afraid it would get stale. There is
currently no private struct on that object either. Sorry! It is not a frequent
function.

> +#define PLUGIN_PROVIDER "org.maemo.Telepathy.Account.Storage.LibAccounts"
> 
> We'll want to define this somewhere that other applications can use, but I'm
> not sure where off-hand.

Yeah, that might need to move soon.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.