[Bug 28200] TpBaseContactList

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Jul 19 16:26:56 CEST 2010


https://bugs.freedesktop.org/show_bug.cgi?id=28200

--- Comment #31 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-07-19 07:26:56 PDT ---
(In reply to comment #29)
> Why did you change those?
> -              g_timeout_add_full (G_PRIORITY_DEFAULT,
> +              g_timeout_add_full (G_PRIORITY_LOW,

Those timeouts emulate network activity; I dropped their priority to get
deterministic results when they race with the default-priority idle used by the
GSimpleAsyncResult. In reality, network activity would be considerably slower.

(In reply to comment #29)
> Some functions document that they can't be called before the contact list has
> been retrieved but doesn't
>   g_return_val_if_fail (self->priv->had_contact_list, NULL);
> This include:
> 
> tp_base_contact_list_get_group_members
> tp_base_contact_list_get_blocked_contacts
> tp_base_contact_list_get_groups
> tp_base_contact_list_get_contact_groups

Fixed in my contact-list-manager branch.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.


More information about the telepathy-bugs mailing list