[Bug 28200] TpBaseContactList

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28200

--- Comment #34 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-07-21 03:49:32 PDT ---
Also to do:

Methods that create groups as a side-effect (like adding members to a
nonexistent group) don't call the create_groups_async virtual method. I think
that's OK - for robustness, the subclass ought to auto-create groups anyway -
but would appreciate confirmation from reviewers.

The create_groups_async virtual method and remove_group_async virtual methods
are asymmetric (plural vs. singular). create_groups_async is never actually
called except when CreateChannel or EnsureChannel is called for a GROUP
ContactList channel, so we could make it singular.

Alternatively, CreateChannel and EnsureChannel could call
set_group_members_async(group, []) or add_to_group_async(group, []) (which the
subclass has to support anyway, because they can be called from D-Bus),
removing the need for an explicit create method.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.