[Bug 29190] Protocol objects don't define a serialization for all their properties

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=29190

--- Comment #1 from Senko Rasic <senko at senko.net> 2010-07-22 05:01:24 PDT ---
Review of 9a71e0:

+RequestableChannelClasses=text

Shouldn't that be "RequestableChannelClasses=text;", since it's a string list?

Also, AFAICT, there are no names associated with the channel classes, so the
section names must be autogenerated. Of course, the names aren't actually used
for anything except serialization here, but it'd be helpful if the spec could
give guidance on how to generate them.

We could e.g. use the channel type suffix and (a representation of) target
handle type, to make the names somewhat human-readable, and append a counter to
each name to ensure uniqueness. This is what I've implemented in gabble branch
implementing Protocol support.

The rest looks fine to me.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.