[Bug 28742] Import Connection.Interface.StoredMessages from rtcom-tp-glib

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28742

Will Thompson <will.thompson at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |26838

--- Comment #5 from Will Thompson <will.thompson at collabora.co.uk> 2010-07-22 08:29:35 PDT ---
(In reply to comment #4)
> The biggest problem with the original interface support by commhistoryd in
> Harmattan was the fact that stored messages includes currently pending
> messages. If such a message is expunged, it's delivered twice. In case of
> tp-ring, only "rescued" can be used to detect a message delivered via expunging
> ("message-received" and "stored-message-received" are always identical and they
> are timestamps, not tokens currently).

I think I've addressed this, by making DeliverStoredMessages() a no-op if
messages are already in PendingMessages on some channel. Sound okay?

> Do we really need two message tokens for re-delivered messages? At least for
> inbound messages, it's not used for anything else but expunge checks and we
> could use just original token.

Yeah, I just binned stored-message-token entirely.

I've also reworded the introduction again, added a 'stored' header that
indicates that the message also appears on this interface, and some other
stuff. I think it's ready to go.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.