[Bug 28200] TpBaseContactList

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28200

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://git.collabora.co.uk/ |http://git.collabora.co.uk/
                   |?p=user/smcv/telepathy-glib |?p=user/smcv/telepathy-glib
                   |-smcv.git;a=shortlog;h=refs |-smcv.git;a=shortlog;h=refs
                   |/heads/contact-list-manager |/heads/contact-list-the-rev
                   |                            |enge

--- Comment #38 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-07-28 05:43:41 PDT ---
I believe David has reviewed as far as
5c18a27e9200bf1874cc15d807c3d009050b3f3b, with no criticisms except for this:

(In reply to comment #35)
> +      GPtrArray *pa;
> doesn't really tell me what you're about to do with it. s/pa/new_interfaces/ or
> something? You use that variable name in a few places in base-contact-list.c,
> but nowhere else in tp-glib.

which is fixed in a later patch, and IMO is very minor. Accordingly, I've moved
contact-list-reviewed to point to that commit.

Subsequent branches for review are contact-list-draft3 and
contact-list-the-revenge, each of which breaks API to keep up with changes I
propose to make in telepathy-spec.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.