[Bug 29018] Allow interactive TLS certificate verification

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Jul 30 16:33:31 CEST 2010


https://bugs.freedesktop.org/show_bug.cgi?id=29018

--- Comment #14 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-07-30 07:33:30 PDT ---
In Connection.xml:
> -      <tp:enumvalue suffix="Cert_Other_Error" value="13">
...
> +      <tp:enumvalue suffix="Cert_Other_Error" value="16">

This is an incompatible change to a non-DRAFT interface; I hope you can see why
it's incompatible?

You'll have to add the new members at the very end of the enum instead, with
correspondingly large numbers; this will mean that Cert_Other_Error isn't the
last cert error, but such is life.

In errors.xml:
> -        This corresponds to Insecure_Algorithm
> +        This corresponds to Cert_Insecure in the 
> +       <tp:type>Connection_Status_Reason</tp:type> enum and to Insecure_Algorithm

I think you mean Insecure; I notice you've also added trailing whitespace on
the line above, please fix that too.

After fixing these, I think this should be ready to merge as a draft, but
please let me have another look first (since it touches stable API).

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.



More information about the telepathy-bugs mailing list