[Bug 27676] ContactInfo high-level API

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27676

Xavier Claessens <xclaesse at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #26 from Xavier Claessens <xclaesse at gmail.com> 2010-06-03 06:02:49 PDT ---
(In reply to comment #25)
> > -  g_object_unref (cancellable);
> >  
> > -  g_idle_add (contact_info_request_cancel, cancellable);
> > +  g_idle_add_full (G_PRIORITY_HIGH, contact_info_request_cancel,
> > +      cancellable, NULL);
> >  
> >    g_main_loop_run (result.loop);
> >    g_assert_no_error (result.error);
> >  
> >    reset_result (&result);
> >    tp_handle_unref (service_repo, handle);
> > +  g_object_unref (cancellable);
> 
> Strictly speaking, the g_idle_add_full and the g_object_unref should be
> combined like so:
> 
>   g_idle_add_full (G_PRIORITY_HIGH, contact_info_request_cancel,
>       cancellable, g_object_unref);
> 
> to guarantee that the cancellable lives long enough for the idle to go off. r+
> with that change.

asserts in contact_info_request_cancelled_cb() will fail if the
g_main_loop_run() returns before the idle callback is called, so that shouldn't
be a problem... But did the change anyway, it's nicer like that :)

Branch merged in master, finally!

Thanks for the detailled reviews :D

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.