[Bug 28200] TpBaseContactList

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28200

--- Comment #12 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-06-04 05:51:37 PDT ---
(In reply to comment #9)
> I've pushed more fixes to smcv/contact-list-manager.
> 
> If you're feeling really enthusiastic about reviewing,
> smcv/contact-list-new-signals and smcv/contact-list-new-methods additionally
> implement the new APIs.

I've rewound smcv/contact-list-new-methods a bit, so it only includes the bits
that I think will rebase cleanly onto the changes I'm making to
contact-list-manager to implement the errata in Comment #9.

(In reply to comment #11)
> smcv/contact-list-new-signals
> ------------------------------
> 
> +  gboolean svc_contact_list;
> +  gboolean svc_contact_groups;
> 
> Add a comment explaining the semantic of these bool and how/why we use it? It's
> pretty straightforward when reading the branch but that's uncommon enough to be
> worth a comment I think.

Fixed, I think.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.