[Bug 28200] TpBaseContactList

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28200

--- Comment #17 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2010-06-07 00:45:23 PDT ---
(In reply to comment #15)
> (In reply to comment #13)
> > I've implemented this in smcv/contact-list-manager. Thinking about it, I don't
> > think the contact's state should visibly change when pre-approving like this,
> > so I didn't implement that bit.
> 
> ... but that's OK, because the spec didn't say that I should either :-)
> 
> I've rebased smcv/contact-list-new-signals onto the new API. The only
> non-automatic changes were to resolve a conflict in this commit:
> 
> http://git.collabora.co.uk/?p=user/smcv/telepathy-glib-smcv.git;a=commitdiff;h=676a5d18a9c2b351649df76dd929336ad9714302
> 
> and to assert about ContactsChanged signals in
> /contact-lists/add-to-publish/pre-approve in this commit:
> 
> http://git.collabora.co.uk/?p=user/smcv/telepathy-glib-smcv.git;a=commitdiff;h=1402e88674e70177de4d2ae5432773bbe2026d4b
> 
> May I consider smcv/contact-list-new-signals to have been reviewed, conditional
> on getting the spec merged? If so, I'll use that as my new baseline for
> changes.

Yeah that's fine with me.

Let me know when there is more code to review.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.