[Bug 28334] Test library missing namespace (making it much more difficult to bind in other languages)

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28334

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|review-                     |review+ with minor changes

--- Comment #4 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-06-07 02:50:30 PDT ---
Thanks, this looks much better. review+ with a couple of changes:

> -   * regression test that's going to be run under a temporary session bus,
> +   * regression tp_tests that's going to be run under a temporary session bus,

Over-zealous sed detected :-)

> -#endif
> +#endif /* #ifndef __TP_TESTS_LIB_UTIL_H__ */
> -#endif
> +#endif /* ifndef __TP_TESTS_CONTACTS_CONN_H__ */

If anything, I'd be inclined to *remove* this comment from the multi-inclusion
header guards. It doesn't seem to me as though it adds value (it should be
obvious that the last #endif in a header is for the multi-inclusion guard) and
it's one more thing to (fail to) change when basing a new header file on an old
one.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.