[Bug 28312] Make TpContact emit a presence-changed signal

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28312

--- Comment #6 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-06-14 03:25:07 PDT ---
Review of attachment 36227:
 --> (https://bugs.freedesktop.org/review?bug=28312&attachment=36227)

::: telepathy-glib/contact.c
@@ +1678,1 @@
   g_object_notify ((GObject *) contact, "presence-type");

I have one remaining concern here, which is that this changes the behaviour of
notify::presence-* - previously, all three properties were updated before
emitting any of the notification signals (which seems most useful to me), but
now, they're updated one at a time.

If you have time to correct this before I do a telepathy-glib 0.19.7 release
today, great; if not, I'll probably apply your patch, make the change myself,
and get someone else to review it.

Thanks for your patience!

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.