[Bug 27269] review and clean up TplContact public API

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27269

--- Comment #19 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2010-06-15 10:11:34 PDT ---
(In reply to comment #18)
> > +  tpl_entity_sender = _tpl_entity_from_tp_contact (me);
> > +  _tpl_entity_set_entity_type (tpl_entity_sender, TPL_ENTITY_USER);
> 
> Pre-existing bug: in both on_received_signal_cb and on_sent_signal_cb,
> shouldn't the entity created from @me be of type TPL_ENTITY_SELF?

Make sense to me.
KA: do you confirm?

> >    /* contact is a user (buddy) */
> > -  TPL_CONTACT_USER,
> > +  TPL_ENTITY_USER,
> 
> Now that the word "contact" isn't in the API, I think TPL_ENTITY_USER should be
> renamed to TPL_ENTITY_CONTACT. Remote contacts aren't necessarily users of our
> software, whereas the local user is: so in telepathy-spec we frequently say
> "the local user" to mean the equivalent of TPL_ENTITY_SELF, and "the remote
> contact" to mean the equivalent of TPL_ENTITY_USER.

Fair enough. I renamed it.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.