[Bug 28199] port Gabble to TpContactListManager/TpBaseContactList

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28199

--- Comment #2 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-06-17 09:22:14 PDT ---
On Bug #28200, Guillaume wrote:
> Looks good except
> http://git.collabora.co.uk/?p=user/smcv/telepathy-glib-smcv.git;a=commitdiff;h=ae0c4aed9b8f878806a51f8e14d9a4ed57a65184
> 
> Shouldn't we fix Gabble instead?

Accordingly, I've appended a patch to roster-assumptions to use the self-handle
as the actor for changes to the deny list, matching TpBaseContactList's
behaviour.

In principle we could do the same for Group changes, but I haven't yet.

For List changes, it's not always obvious who the actor is. For instance, when
a contact accepts our subscription request, we can get the roster push from the
server before the <presence type='subscribed'/> (assuming test-google-roster.py
is realistic), so we can't assume that unsolicited roster pushes are always
from one of our own resources.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.