[Bug 28599] regression in 0.9.13: fails to connect to jabberd2 2.2.7.1

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28599

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
  Status Whiteboard|                            |review+ with trivial change
         AssignedTo|telepathy-bugs at lists.freede |will.thompson at collabora.co.
                   |sktop.org                   |uk

--- Comment #3 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-06-18 06:34:46 PDT ---
Functionally, this looks fine. One style point:

>    if (disco_error != NULL)
> +    DEBUG ("Got disco error on bare jid: %s", disco_error->message);
> +  else
> +    for (i = node_iter (result); i; i = node_iter_next (i))
> +      {

I think the if and else blocks should have {} for clarity, because the for-loop
is more than one statement.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.