[Bug 28826] KeyFile should support spaces in key names and string list params that don't terminate with ;

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28826

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
  Status Whiteboard|                            |needs tests
         AssignedTo|telepathy-bugs at lists.freede |andrunko at gmail.com
                   |sktop.org                   |

--- Comment #2 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-06-30 05:47:16 PDT ---
There should be a regression test for a key containing a space.

There should be regression tests for string lists that do and don't end with
";". The protocol "somewhat-pathological" in
tests/telepathy/managers/test-manager-file.manager is an example of what test
data for this sort of thing ought to look like: please parse all the default
values.

> -        // as an extension to the Desktop Entry spec, we allow "_", "." and "@"
> +        // as an extension to the Desktop Entry spec, we allow " ", "_", "." and "@"
>          // as valid key characters - "_" and "." are needed for keys that are
>          // D-Bus property names, and GKeyFile and KConfigIniBackend also accept
>          // all three of those characters.

All four of those characters? :-P

Fact-check: does KConfigIniBackend actually accept those? I hope so...

FYI, GKeyFile rejects spaces at the beginning or end of a key, and has special
handling for square brackets (they must be paired and can only contain
alphanumerics or "-_.@", which are enough for all locales).

We should watch out for this in telepathy-spec in future...

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.