[Bug 20831] ContactInfo: implement and undraft

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=20831


Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|review+                     |




--- Comment #20 from Simon McVittie <simon.mcvittie at collabora.co.uk>  2010-03-01 12:20:21 PST ---
Removing review+ since there's new code; I've appended patches to fix the major
problems and improve test coverage.

(In reply to comment #18)
> * The SupportedFields property is not connection-specific, so we can't separate
> it for GTalk.

Fixed

> * It's permissive about incoming vCard fields, but then silently drops anything
> it doesn't like.

Fixed

> * SupportedFields should list their supported type-parameters, and
> SupportedFields that can't have any type-parameters at all should have the
> Parameters_Mandatory flag.

Fixed

> * Minor: it would be nice to detect the Facebook XMPP server, and on
> connections to that server, clear the SupportedFields and the Can_Set bit.

Not fixed, I'll open a bug for this

(In reply to comment #19)
> Another flaw here is that ContactInfoChanged doesn't optimize away no-op
> changes.

Not fixed, I think this is acceptable


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.