[Bug 24994] Connect example doesn't initialize WockyXmppNode

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=24994


Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          QAContact|                            |telepathy-
                   |                            |bugs at lists.freedesktop.org




--- Comment #1 from Simon McVittie <simon.mcvittie at collabora.co.uk>  2010-03-09 09:43:42 PST ---
 200   if (strcmp (stanza->node->name, "features")
 201       || strcmp (wocky_xmpp_node_get_ns (stanza->node),
WOCKY_XMPP_NS_STREAM))
 202     {
 203       printf ("Didn't receive features stanza\n");
 204       g_main_loop_quit (mainloop);
 205       return;
 206     }
 207 
 208   wocky_xmpp_node_init ();

Why is w_x_n_i only called after we've already interacted with stanza->node?

Shouldn't construction of any WockyXmppStanza implicitly initialize
WockyXmppNode?

Or, if w_x_n_i is a mandatory initialization function like g_type_init (but:
ugh), shouldn't it be called from main()?


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.