[Bug 24939] Interface for upgrading chats/calls to multi-user

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=24939





--- Comment #17 from Jonny Lamb <jonny.lamb at collabora.co.uk>  2010-03-11 05:09:05 PST ---
I just implemented the conference interface in butterfly, and in general, I
have no changes to propose or problems to point out.

However, I would say that it's actually rather a complicated interface to
understand. It took a while to work out, but maybe that was me? Without a
doubt, SupportsNonMerges was the most complicated to understand. I spoke to
Simon about it yesterday, and am still not exactly clear on its use:

18:04 < smcv> jonnylamb: also put SupportsNonMerges in the allowed, if 
              that's what you support
18:04 < smcv> jonnylamb: (as documented)
18:04 < smcv> "An XMPP 1-1 conversation C1 can be continued in a newly 
              created multi-user chatroom Cn by calling 
              CreateChannel({...ChannelType: ...Text, ...InitialChannels: 
              [C1]})  which returns Cn"
18:04 < smcv> says the spec
18:05 < smcv> so our CMs should support that usage, really
18:05 < jonnylamb> Hm, I'm a little confused about that property. Why would 
                   it be requestable? I don't see a case where it wouldn't 
                   be True in butterfly.
18:05 < smcv> jonnylamb: it's sort of fake-requestable... it exists only to 
              indicate static CM capabilities
18:06 < smcv> jonnylamb: you should allow it to appear in requests but 
              ignore its value, probably
18:06 < smcv> jonnylamb: it's a way to tell "oh shit, this is GSM" :-)
18:07 < jonnylamb> So something in allowed properties doesn't mean the CM 
                   will take any notice of its value?
18:07 < smcv> yes. I know it's a bit mad
18:07 < jonnylamb> (At the moment, butterfly hardcodes its value to True.)
18:08 < smcv> as long as we preserve the invariant that there exists at 
              least one value you could genuinely put in your request, I 
              think it's OK
18:08 < smcv> in general there's no guarantee that the returned channel will 
              match what you asked for
18:08 < smcv> as long as it's "close enough" (as defined by the actual 
              interface being implemented)

Yeah, in fact, I'd say SupportsNonMerges would be the only thing I'm not so
happy about at all in conference. As butterfly sets it to True in all cases, I
guess it's not such a big deal for butterfly.

So, yeah, butterfly is a happy user of the conference interface now. Hopefully
it can be merged soon. :-)


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.