[Bug 27014] Implement conference interface

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=27014





--- Comment #2 from Jonny Lamb <jonny.lamb at collabora.co.uk>  2010-03-11 05:42:43 PST ---
(In reply to comment #1)
> TP-Python :

I won't amend any previous commits to make it easier to review.

>  * requests: 0 is a valid TargetHandleType
> Ok but we should probably check against <= LAST_HANDLE_TYPE for the uper limit

Done.

>  * channel: TargetHandle=0 if the channel handle is None
> It would probably better to have a NoneHandle object whose get_id() return 0
> instead of using None when there is no Handle, this would avoid having special
> cases like this everywhere.

Done.

>   * channel: don't find the channel handle if TargetHandleT... 
> Only one IF would work as well

Done.

>   * channel: add a comment on get_props to clarify more...
> Nitpicking but proper python docstring would be nicer

Done.

>   * channelmanager: rename requestable_channel_classes... 
> What's the point ?

Because it is now called what it does, as opposed to something else. It doesn't
contain any channel classes.

>   * channelmanager: add implement_channel_classes function
> Please document the new function, especially the arguments

Done.

> Maybe display a deprecation warning

Hm, how can I do this but be sure that dbus-python won't pick it up and use it
as a dbus method error?

My branch has been updated with the above changes.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.