[Bug 27014] Implement conference interface
bugzilla-daemon at freedesktop.org
bugzilla-daemon at freedesktop.org
Fri Mar 12 00:56:33 CET 2010
http://bugs.freedesktop.org/show_bug.cgi?id=27014
--- Comment #7 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2010-03-11 15:56:32 PST ---
(In reply to comment #4)
> This only a preliminary review, I didn't test it, because I would rather want
> to wait you divide the two use case in two separate classes. The TextChannel
> class as it is in this patch is barely understandable and maintainable.
I've done this. From the commit message:
text channel: split into three subclasses: Im, Muc and Conference
ButterflyTextChannel was getting a little heavy. The class hierarchy
now goes like this:
telepathy.server.Channel
+----telepathy.server.ChannelTypeText
+----ButterflyTextChannel
+----ButterflyImChannel
+----ButterflyMucChannel
+----ButterflyConferenceChannel
Simple.
Enjoy reviewing!
--
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the telepathy-bugs
mailing list