[Bug 27042] Improve typing notifications

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=27042





--- Comment #2 from Olivier Le Thanh Duong <olivier at lethanh.be>  2010-03-12 11:23:58 PST ---
(In reply to comment #1)
> Okay, I implemented this, and it seems to work nicely butterfly <-> butterfly.
> I am unable to test it butterfly <-> Live Messenger, but I don't see how
> anything would be broken, really.
> 
> I based it on top of my conference butterfly branch as I didn't want merge hell
> later, so this can obviously only be merged once the said other branch is
> merged.
> 
> I've made this bug depend on the conference one.
> 

I don't think it's actually useful that we have a timeout for resending our own
typing notification since Empathy itself with change to CHAT_STATE_PAUSED when
the user stop typing after a few seconds then will re-change to
CHAT_STATE_COMPOSING when the user start typing again. So the only thing we are
doing in maskin the PAUSED state (or the corner case where a user is typing non
stop for more that 5 seconds)

in    def steal_conversation(self):
+        self._remove_typing_timeouts()
if we received a typing notification from the contact right before stealing the
contact he will constantly be shown as typing


+            self._typing_notifications[handle] = 0
Why not just delete it from the dictionary instead of setting it as 0?


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.