[Bug 27021] crash when calling CreateAccount with a malformed property

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=27021


Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|patch                       |
  Status Whiteboard|                            |review-




--- Comment #2 from Simon McVittie <simon.mcvittie at collabora.co.uk>  2010-03-15 06:59:05 PST ---
I don't think this patch is right. If set_error is non-NULL, you'll copy it
into cad->error, then use g_set_error to put an MCD_ACCOUNT_MANAGER_ERROR into
cad->error, leading to a GLib assertion failure.

What you probably want to do is to have set_new_account_properties() put its
error into a temporary variable, which is then propagated into cad->error? Or
don't call g_set_error if cad->error is already non-NULL? Or refactor the
function so that cad->ok and cad->error are always set at the same time,
reducing confusion considerably? Or something.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.