[Bug 24699] don't abuse M_T_Action for nudges

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=24699


Jonny Lamb <jonny.lamb at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|should not advertise        |don't abuse M_T_Action for
                   |Message_Type_Action unless  |nudges
                   |able to deal with all       |
                   |messages of that type       |




--- Comment #3 from Jonny Lamb <jonny.lamb at collabora.co.uk>  2010-03-15 09:50:45 PST ---
We already do this:

method call sender=:1.48 -> dest=:1.28 serial=131
path=/org/freedesktop/Telepathy/Connection/butterfly/msn/jonny_40jonnylamb_2ecom/TextChannel1;
interface=org.freedesktop.Telepathy.Channel.Type.Text; member=GetMessageTypes
method return sender=:1.28 -> dest=:1.48 reply_serial=131
   array [
      uint32 0
   ]


16:42 < jonnylamb> smcv: I'm confused as to what you're actually asking 
                   for in fd.o#24699 now.
16:42 < jonnylamb> smcv: You note in the Empathy bug that butterfly only 
                   returns NORMAL in GetMessageTypes().
16:42 < jonnylamb> So surely "should not advertise Message_Type_Action 
                   unless able to deal with all messages of that type" is 
                   satisfied?
16:43 < smcv> jonnylamb: if that is the case then yes
16:44 < smcv> jonnylamb: I was wrong about the butterfly bug initially, I 
              thought butterfly advertised Normal and Action but Action 
              only worked for nudges
16:44 < jonnylamb> You're right about the second part -- if we're given 
                   an action message type and it's a nudge then we send a 
                   nudge over the wire, otherwise we, don't?
16:45 < smcv> (Normal, *) -> "*"
16:45 < istaz> jonnylamb: it was about the /nudge, we only return NORMAL 
               but empathy don't check that, and /nudge is only accepted 
               as ACTION_TYPE and don't accept if that's not /nudge
16:45 < jonnylamb> But seeing as we don't advertise ACTION, I think we 
                   can do what the hell we want if someone gives us an 
                   Action message. :-)
16:45 < smcv> (Action, "nudge") -> protocol nudge
16:45 < smcv> (Action, "dies") -> error
16:45 < smcv> jonnylamb: in principle you're right, although I still 
              think it's an abuse of Action messages
16:46 < smcv> and the Empathy bug isn't blocked by the butterfly bug as I 
              initially thought, but is still a rather annoying bug
16:46 < jonnylamb> I'm actually in favour of removing nudge support in 
                   butterfly.
16:46 < smcv> s/in butterfly// :-)
16:46 < jonnylamb> Maybe we should hook it up so if a contact nudges you, 
                   he or she is automatically blocked.
16:48 < jonnylamb> Anyway, I'm going to close that bug because it's not a 
                   bug. If you want the bug to mean something else, say 
                   now or forever hold your peace.
16:48 < smcv> indeed, nudging should either be ignored, or be a 
              Channel.Interface.Annoyance or something (which Empathy 
              would implement as the URGENT hint
16:48 < smcv> )
16:49 < smcv> jonnylamb: would you mind re-purposing it as "don't abuse 
              M_T_Action for nudges"? (if so you can drop the severity of 
              course)
16:49 < jonnylamb> ok


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.