[Bug 27125] Add support to QT_NO_CAST_FROM_ASCII

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=27125





--- Comment #3 from Simon McVittie <simon.mcvittie at collabora.co.uk>  2010-03-17 07:46:20 PST ---
(In reply to comment #2)
> (In reply to comment #1)
> > This is going to regress unless `make check` checks it.
> 
> Indeed, but this is an optional flag that we support. We can't make it
> mandatory.

Am I right in thinking that QT_NO_CAST_FROM_ASCII is like G_DISABLE_DEPRECATED
or -Wsomething, in that it disables questionable functionality without altering
the API/ABI that we export? If so, why can't we make it mandatory for the
compilation of telepathy-qt4 itself?

(I agree that we shouldn't make it mandatory for the compilation of *projects
that depend on* telepathy-qt4.)

If the cast-from-ascii version needs testing too, perhaps we could re-enable
casting to/from ASCII in $(DISTCHECK_CONFIGURE_FLAGS), so the best-practice
version happens normally, and the other version happens during distcheck? (This
mirrors the situation for debug code in telepathy-glib, which is on by default,
but is switched off during distcheck to check that the library still builds.)

If that's also problematic for some reason, doing the opposite (checking
QT_NO_CAST_FROM_ASCII at distcheck time) could be used as a last resort.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.