[Bug 27154] terminating action chain in pendingproc_connect_signals() leads to crash

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=27154





--- Comment #1 from Danielle Madeley <danielle.madeley at collabora.co.uk>  2010-03-17 23:29:36 PST ---
Ok. This patch cleans a few things up, it makes channel registering a bit less
messy, and fixes a leak in TplActionChain that means it's now possible to
finalize a channel. When the dead channel is finalized it stops receiving
signals and later crashing the logger.

http://git.collabora.co.uk/?p=user/danni/telepathy-logger.git;a=commitdiff;h=9cd9a58d7331a96e20f262402628b81dfc675c68

Freeing the action chain is now moved from tpl_actionchain_continue/terminate
to tpl_actionchain_finish, otherwise you can't get the result.

The bug was that tpl_actionchain_free() didn't free the GSimpleAsyncResult, so
it leaked, along with its ref to the source object. That has now been fixed, so
we can't free it before we get the result.

Also includes the contents of tpl-conf-iface commit
7971e1a0d6101cd125381ca1860f7c79ef8f74d0 which I independently came across and
then realised was the same thing.

~

Need to still fix the bug where channels not implementing Messages never get
logged.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.