[Bug 27167] New: Gabble MailNotification.RequestInboxURL returns empty string

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=27167

           Summary: Gabble MailNotification.RequestInboxURL returns empty
                    string
           Product: Telepathy
           Version: git master
          Platform: All
               URL: http://git.collabora.co.uk/?p=user/nicolas/telepathy-
                    gabble.git;a=commit;h=1810fc8fd1a11da61521c9c2ea44f09d08
                    070bf6
        OS/Version: All
            Status: NEW
          Keywords: patch
          Severity: normal
          Priority: medium
         Component: gabble
        AssignedTo: telepathy-bugs at lists.freedesktop.org
        ReportedBy: nicolas.dufresne at collabora.co.uk


This happens when RequestInboxURL is called right after Subscribe. Subscribe
method launches an request for initial data but does not wait for the reply.
Has RequestInboxUrl rely on the result of this reply, the method keeps
returning empty string until the data arrived.

The solution I wrote is to return from Subscribe call after the request for
data terminates. Another solution I could have used is to return from the
RequestInboxURL after the data has arrived. The benefit of the first solution
over the second is that you never get the initial unread-count right, instead
of getting 0 and then the real number. The cons of this method is that
according to the spec Subscribe cannot return a network error, which could
happen if the server fails to respond. If that happen, Subscribe will return
normally, the InboxURL will be empty string and count will be 0.

http://git.collabora.co.uk/?p=user/nicolas/telepathy-gabble.git;a=commit;h=1810fc8fd1a11da61521c9c2ea44f09d08070bf6


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.