[Bug 25493] GTalk-compatible file transfers are not implemented

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=25493





--- Comment #14 from Youness Alaoui <youness.alaoui at collabora.co.uk>  2010-03-22 12:25:38 PST ---
So, after a long discussion over IRC, here is a summary of the tasks that I
need to do to fix the various issues discussed previously :
- renaming GtalkFTManager into GTalkFileCollection
- rename JingleChannel (and jingle channel references) into ShareChannel
- move the manifest parsing into the GabbleFileTransferChannelManager and
remove the call to 'gabble_file_transfer_channel_new' from the
GTalkFileCollection
- rename gabble_file_transfer_channel_set_gtalk_ft_state into
gabble_file_transfer_channel_gtalk_ft_state_changed to make it clear it's a
'signal-like' API.
- add comments explaining the design and layering violation, as well as the
protocol and object associations
- remove GabbleChannel and use the channel's 'ACCEPTED' state for 'usable' and
use a GHashTable for the 'readable' fields of GabbleChannel.


Here is a list of the other issues discussed previously that were not addressed
yet or to which I didn't previously reply with 'fixed' :
- Do you still want me to cherry-pick the bytestrean/bytestream typo fix ?
- You still want me to remove/refactor the 'media-type' property ?
- 'blank line around blocks' -> forgot to say 'fixed'
- remove the check for error != NULL around g_set_error -> after discussion
with Will, I've fixed it.
- asked to avoid 'idx' variable, forgot to say that the code was removed
anyways
- The whole algorithm for group_and_send_candidates was changed, any comments
on the new algo ?
- strict aliasing issues with g_has_table_iter_next?
- Is it fine to not use gabble_generate_id?
- How about the hard-coding special treatment in GabbleJingleContent? Should I
find a better solution to all that ?
- You got a solution to the re-entrance issues with
gtalk_file_collection_terminate? 
- Merge jingle/share-Channel functionality into jingle-share ?
- We forgot to discuss on how to handle SI vs. jingle-share decision in gabble.
- other strict aliasing issue with content_new_channel_cb.

That's it.
Thanks again!


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.