[Bug 13351] Forwarding spec

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=13351





--- Comment #9 from Andres Salomon <dilinger at collabora.co.uk>  2010-03-22 17:23:11 PST ---
(In reply to comment #7)
> ForwardingRulesChanged: either rename to ForwardingRuleChanged because it has
> data for one rule only, or make it able to emit multiple rules (maybe the
> entire set currently active?); the latter change will remove the atomicity
> issue which is mentioned in the documentation to SetForwardingRule.
> 

BTW, the reason this only emits one rule change at a time is to make dependency
changes explicit for clients.  A client changes a rule; if the CM proceeds to
modify multiple rules due to that, we have two possibilities:

1) ForwardingRulesChanged is emitted (once) and supplies the new list of active
rules.  A client might only check that the signal was emitted before updating
the UI, or might only check that the rule it was looking for was changed.  In
order to catch these kinds of changes, the client/UI would need to go through
the entire list of rules and update the UI accordingly.  Failure to do this
could result in a mismatch between the CM and the UI. 

2) ForwardingRuleChanged is emitted for each rule change.  A client should
notice multiple signals and update the UI for each accordingly.  A UI might
simply be watching for a signal, which should result in a bug as the UI sees
multiple signals (a bug which is less subtle than "hm, the UI and what's
actually happening when I get a phone call don't actually match up").


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.