[Bug 24905] Emergency call identification

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=24905





--- Comment #6 from Andres Salomon <dilinger at collabora.co.uk>  2010-03-23 16:31:07 PST ---
(In reply to comment #5)
> drive-by feedback:
> 
> • maybe GetCurrentService() → s, u should just be a pair of d-bus
> properties, ServicePoint and ServicePointType?

Hm, possibly.  I'm tempted to group them together as a struct; would that be
acceptable?

> • the point of the enum is so that your UI can tell it's an emergency call
> without having to parse the string, but if you want you can find out that in
> particular it's an emergency call to the fire brigade, right? if so, shouldn't
> there also be an InitialServicePointType property?
> 

Good point, just added it.  Thanks.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.